[#6834] Requires GNU Make on OpenBSD

Date:
2024-01-12 16:07 Priority:
3

State:
Closed

Submitted by:
Ivan Krylov (ikrylov) Assigned to:
Nobody (None)

Hardware:
None Product:
None

Operating System:
other Component:
None

Version:
None Severity:
None

Resolution:
Fixed

URL:

Summary:
Requires GNU Make on OpenBSD

Detailed description
Trying R CMD build with SVN revision 4562 on OpenBSD 7.4 results in the following error message during package installation: egcc -I"/home/user/R-build/include" -DNDEBUG -I./SuiteSparse_config -DNTIMER -I/usr/local/include -fvisibility=hidden -fpic -g -O2 -c validity.c -o validity.o ( cd Lib ; make clean ) ( cd Source ; make clean ) ( cd Source ; make clean ) ( cd Lib ; make ) cc -c ../Core/cholmod_aat.c -o cholmod_aat.o ../Core/cholmod_aat.c:32:10: fatal error: 'cholmod_internal.h' file not found #include "cholmod_internal.h" ^~~~~~~~~~~~~~~~~~~~ 1 error generated. * Error 1 in CHOLMOD/Lib (Makefile:174 'cholmod_aat.o') * Error 2 in CHOLMOD (Makefile:15 'library') *** Error 1 in /tmp/Rtmp0olMKV/Rbuild1230f7185b044/Matrix/src (Makevars:29 'sublibraries': @for d in CHOLMOD COLAMD AMD SuiteSparse_config; ...) ERROR: compilation failed for package _Matrix_ For some reason, the final Make subprocess seems to be missing the CC=egcc and CFLAGS=... variables. Looking at the `make -d vl` output, the final Make process (launched by ( cd Lib ; $(MAKE) )) doesn't see the $(MkInclude). Only /usr/share/mk/sys.mk and Makefile are on the MAKEFILE_LIST) when launched by OpenBSD make. Not yet sure what's the best way to fix this, but at least the workaround is simple: launch R CMD <...> with MAKE=gmake.

Comments:

Message
Date: 2024-01-12 21:03 Sender: Mikael Jagan No problem, and thanks anyway for the report. FWIW, we're aiming to change soon to a more R-like Subversion set-up, with all development happening in pkg/Matrix/ and changes being ported to branches/Matrix-x-y-branch/ as needed.
Date: 2024-01-12 20:14 Sender: Ivan Krylov Indeed, branches/Matrix_1.7-0_branch works well with OpenBSD make! Sorry I didn't notice it and only checked pkg/Matrix.
Date: 2024-01-12 16:36 Sender: Mikael Jagan By any chance, is this issue already fixed in branches/Matrix_1.7-0_branch/, which will be merged soon into pkg/Matrix/ (our "trunk")?

Field	Old Value	Date	By
status_id	Open	2024-01-12 21:03	jaganmn
close_date	None	2024-01-12 21:03	jaganmn
Resolution	None	2024-01-12 21:03	jaganmn