SCM

[#1398] GenABEL fails CRAN checks

Date:
2011-05-17 17:29
Priority:
5
State:
Closed
Submitted by:
Yurii Aulchenko (yurii)
Assigned to:
Nobody (None)
Resolution:
Fixed
Operating System:
None
Severity:
blocker
Hardware:
None
Version:
None
Component:
GenABEL
URL:
Summary:
GenABEL fails CRAN checks

Detailed description
from PeterD:

Dear maintainers of

BMA GenABEL SNPassoc cherry.

Your packages are currently failing the automatic CRAN checks under r-devel. This is due to a change in the labeling of columns in anova tables, which you have been using to extract p values.

E.g. (from "cherry")

anova(glm(form, data=birthwt, family=binomial), fullfit, test="Chisq")$"P(>|Chi|)"[2]

does no longer work because the column is now labeled "Pr(>Chi)".

Since you probably don't want to break compatibility with R 2.13.x, you can't just change the string. Instead, the straightforward workaround would seem to be

t1 <- glm(form, data=birthwt, family=binomial), fullfit, test="Chisq")
t2 <- t1$"P(>|Chi|)"
if (is.null(t2)) t2 <- t1$"Pr(>Chi)"
t2[2]

Or, at some loss of readability:

t1[2, grep("^P.*Chi",names(t1))]

Apologies for the inconvenience, but please adjust your packages and resubmit to CRAN.

Comments:

Message  ↓
Date: 2011-05-17 23:32
Sender: Yurii Aulchenko

Fixed by use of "t1[2, grep("^P.*Chi",names(t1))]"-like solution

Attached Files:

Changes

Field Old Value Date By
status_idOpen2011-05-17 23:32yurii
close_date2011-05-17 23:322011-05-17 23:32yurii
ResolutionAccepted As Bug2011-05-17 23:32yurii
Thanks to:
Vienna University of Economics and Business Powered By FusionForge