SCM

[#1126] Using mach2databel() or impute2mach() to convert files to the filevector format leaves fvtmp filles behind

View Trackers | Bugs | Download .csv | Monitor

Date:
2010-10-11 21:50
Priority:
3
State:
Closed
Submitted by:
Lennart Karssen (lckarssen)
Assigned to:
Lennart Karssen (lckarssen)
Resolution:
Accepted As Bug
Operating System:
Linux (64bit)
Severity:
minor
Hardware:
None
Version:
other
Component:
DatABEL
URL:
 
Summary:
Using mach2databel() or impute2mach() to convert files to the filevector format leaves fvtmp filles behind

Detailed description
Observed behaviour:
I recently used the functions impute2mach() and mach2databel() to convert impute and mach files to DatABEL's filevector format. In both cases the .fv? files were created correctly. However, in both cases two files ending in _fvtmp.fvi and _fvtmp.fvd were left behind.
Note: The _fvtmp.fv? file and its corresponding .fv? file have the same size, however, their md5sums differ, so they are not identical.

Expected behaviour:
The functions should only leave the final .fvi and .fvd files. Temporary files should be removed after successful conversion.

Followup

Message
Date: 2014-09-11 09:13
Sender: Lennart Karssen

Fixed in r1640.
Date: 2010-12-07 11:53
Sender: Yurii Aulchenko

I think it may be enough to add an argument (say,
'unlinkTmpTransposeFiles') to text2databel which by default is TRUE
and when TRUE the function 'unlink' the tmp-files at the end of the
procedure. The only trick I see is figuring out the names of these
files :) Ideally, having a check for that in RUnit would be great
Date: 2010-12-07 11:44
Sender: Stepan Yakovenko

Started fixing, but have absolutely no time this week.
As far as I understand, tmp files are made by text2databel, but I didn't manage to understand the sequence of functions that call it.
Date: 2010-12-07 08:31
Sender: Yurii Aulchenko

Apparently these tmp-files are produced while transposinf by 'filevector' transpose in 'text2databel' function of DA only, as far as I could understand. I think we should introduce a default option 'unlinkTmpTransposeFiles=TRUE' which when true should 'unlink' temporary files generated by transposition procedure; when false, act as now (leave them alone)

Attached Files:

Changes:

Field Old Value Date By
close_dateNone2014-09-11 09:13lckarssen
status_idOpen2014-09-11 09:13lckarssen
ComponentGenABEL2014-03-14 23:46lckarssen
Versionv1.6-42014-03-14 23:46lckarssen
assigned_tostiv2014-03-14 23:46lckarssen
assigned_tonone2010-10-21 14:43yurii
ResolutionNone2010-10-13 11:56lckarssen
Thanks to:
Vienna University of Economics and Business University of Wisconsin - Madison Powered By FusionForge