SCM

SCM Repository

[matrix] Diff of /pkg/TODO
ViewVC logotype

Diff of /pkg/TODO

Parent Directory Parent Directory | Revision Log Revision Log | View Patch Patch

revision 2114, Mon Feb 18 17:15:41 2008 UTC revision 2115, Sat Feb 23 09:23:17 2008 UTC
# Line 112  Line 112 
112    present factorization and rather uses one with more '0' in x slot.    present factorization and rather uses one with more '0' in x slot.
113    
114  - diag(m) <- val    currently automatically works via  m[cbind(i,i)] <- val  - diag(m) <- val    currently automatically works via  m[cbind(i,i)] <- val
115    However,    This (`[<-` method) is now "smart" for diagonalMatrix, but needs also to
116    we need methods for 'diag<-' at least for diagonalMatrix,    be for triangularMatrix, and probably also "dense*general*Matrix" since the
   triangularMatrix, and probably also "dense*general*Matrix" since the  
117    above currently goes via "matrix" and back instead of using the 'x' slot    above currently goes via "matrix" and back instead of using the 'x' slot
118    directly.    directly; in particular, the triangular* "class property" is lost!
119    
120  - image(M, ..): Think about an optional smart option which keeps  - image(M, ..): Think about an optional smart option which keeps
121     "0 |-> transparent" and allows colors to differentiate negative and     "0 |-> transparent" and allows colors to differentiate negative and
# Line 167  Line 166 
166    Consider going via  asTuniq() or something very close to    Consider going via  asTuniq() or something very close to
167    .Arith.Csparse() in R/Ops.R    .Arith.Csparse() in R/Ops.R
168    
169  - grep for '*HORRENDOUSLY* slow' in tests/simple.R  - many setAs(*, "[dl]..Matrix") are still needed, as long as e.g.
170    and do better than    replCmat() uses as_CspClass() and drop0(.) which itself call
171          unlist(lapply(seq_len(m), function(j) x[i1[j], i2[j]]))    as_CspClass() quite a bit.  --> try to replace these by
172    in R/Matrix.R    as(*, "CsparseMatrix"); forceSymmetric, etc.
   --> now fixed for sparseMatrices : 'ss <- slp[ij]' in tests/simple.R  
   
   But need similar fix for  m[ <ij-matrix> ] <- value  
   and the same for *dense* Matrices  

Legend:
Removed from v.2114  
changed lines
  Added in v.2115

root@r-forge.r-project.org
ViewVC Help
Powered by ViewVC 1.0.0  
Thanks to:
Vienna University of Economics and Business Powered By FusionForge